Repository navigation
Stop naming an individual install in a script comment - #104
Merged
Merged
Conversation
Comment-only change in scripts/registry-login.sh. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
dmitry-grechko
approved these changes
Nov 18, 2026
dmitry-grechko
left a comment
Member
There was a problem hiding this comment.
This is a one-line comment change in scripts/registry-login.sh with no behaviour change. git grep -i on the branch finds no remaining instance of the name, and the only check, the pack self-test, is green.
Generated by Claude Code
dmitry-grechko
approved these changes
Nov 18, 2026
dmitry-grechko
left a comment
Member
There was a problem hiding this comment.
Comment-only change in scripts/registry-login.sh. There is no behavior change, no other occurrence of the name is left in the tree, and CI is green. Note: once helm-chart #514 merges at 1.1.36, VERSION here has to move to 1.1.36 before that chart is released.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only change in
scripts/registry-login.sh: the note on thedocker --quietfailure no longer names an individual install. A repo rule says a customer, tenant or install is never named in committed text. No behaviour change;bash -npasses.VERSIONstays 1.1.35 (this tree is public, so the change reaches customers with the next release).Already published releases keep the old text; that cannot be edited.
🤖 Generated with Claude Code