Skip to content

Stop naming an individual install in a script comment - #104

Merged
ernesto-deskree merged 1 commit into
mainfrom
chore/reword-comment
Nov 19, 2026
Merged

ernesto-deskree merged 1 commit into
mainfrom
chore/reword-comment

Conversation

@ernesto-deskree

Copy link
Copy Markdown
Contributor

Comment-only change in scripts/registry-login.sh: the note on the docker --quiet failure no longer names an individual install. A repo rule says a customer, tenant or install is never named in committed text. No behaviour change; bash -n passes. VERSION stays 1.1.35 (this tree is public, so the change reaches customers with the next release).

Already published releases keep the old text; that cannot be edited.

🤖 Generated with Claude Code

Comment-only change in scripts/registry-login.sh.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@dmitry-grechko dmitry-grechko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a one-line comment change in scripts/registry-login.sh with no behaviour change. git grep -i on the branch finds no remaining instance of the name, and the only check, the pack self-test, is green.


Generated by Claude Code

@dmitry-grechko dmitry-grechko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment-only change in scripts/registry-login.sh. There is no behavior change, no other occurrence of the name is left in the tree, and CI is green. Note: once helm-chart #514 merges at 1.1.36, VERSION here has to move to 1.1.36 before that chart is released.


Generated by Claude Code

@ernesto-deskree
ernesto-deskree merged commit 81653d2 into main Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants