Sort Features with more user-defined options first, per spec#1267
Open
nozaq wants to merge 1 commit into
Open
Conversation
The Features spec's "Installation Order" rules state that Features in a round are sorted by "Greatest number of user-defined options", but optionsCompareTo compared option counts ascending, installing the Feature with the fewest options first. Flip the length comparison so the Feature with the greatest number of options sorts first, and update the round-sorting test expectations accordingly. Equal-length option sets still tie-break by key/value comparison as before.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Features spec's "Installation Order" rules state that Features in a round are sorted by "Greatest number of user-defined options", but optionsCompareTo compared option counts ascending, installing the Feature with the fewest options first.
Flip the length comparison so the Feature with the greatest number of options sorts first, and update the round-sorting test expectations accordingly. Equal-length option sets still tie-break by key/value comparison as before.
fixes devcontainers/spec#755