Repository navigation
fix(deps): require ucumvert 0.3.3 - #149
Merged
Merged
Conversation
ucumvert releases before 0.3.3 fail to load their unit registry under pint 0.26.2. The lock moves pint to 0.26.2 on Python 3.12 and later, so CI tests that pairing.
vincentsarago
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import titiler_covjsonfails under pint 0.26.2 with any ucumvert release before 0.3.3, because pint 0.26.2 rejects thei.U.alias in ucumvert's unit definitions (dalito/ucumvert#82). ucumvert does not cap pint, so ourucumvert>=0.3.0floor allows that pairing on Python 3.12 and later, where pint 0.26.2 installs. CI on main misses it becauseuv.lockpins pint 0.25.3 and the floor job runs on Python 3.11.This raises the ucumvert floor to 0.3.3, the first release that supports pint 0.26 (dalito/ucumvert#84), in place of the pint bound that PR #142 proposed. The lock also moves pint to 0.26.2 on Python 3.12 and later, so the 3.12 and 3.13 test legs run that pairing. Python 3.11 keeps pint 0.25.3, because pint 0.26.2 requires Python 3.12.
The new floor also fixes a 500 when a band's
unitstag is a bare UCUM annotation such as{count}._create_parameterpasses the tag tocreate_unit, which raisesAttributeErroron ucumvert 0.3.2, while 0.3.3 converts the annotation to unity (dalito/ucumvert#86).The ucumvert lock change is the same as PR #148's.