#2110 add documentation for contributing to UI components - #2291
Open
laim2003 wants to merge 6 commits into
Open
#2110 add documentation for contributing to UI components#2291laim2003 wants to merge 6 commits into
laim2003 wants to merge 6 commits into
Conversation
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
Signed-off-by: laim2003 <luk.faber@gmx.de>
laim2003
added
documentation
laim2003
marked this pull request as ready for review
August 7, 2026 08:34
Collaborator
Coverage Report for CI Build 31963413086Warning No base build found for commit Coverage: 72.918%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
laim2003
changed the title
Signed-off-by: laim2003 <luk.faber@gmx.de>
JoelAdbu
reviewed
Aug 10, 2026
JoelAdbu
left a comment
JoelAdbu
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the documentation. Looks very good to me, with a solid level of detail and practical examples. The architecture decisions and recommended patterns as well as the contribution process are explained clearly and should provide good guidance for future contributors.
…ing-to-ui-components-clean
laim2003
commented
Aug 10, 2026
Comment on lines
+68
to
+91
| gui/ | ||
| ├── src/ | ||
| │ └── main/ | ||
| │ └── java/ | ||
| │ └── com/ideasy/gui/ | ||
| │ ├── feature/ | ||
| │ │ ├── dashboard/ | ||
| │ │ │ ├── DashboardController.java | ||
| │ │ │ ├── DashboardModel.java | ||
| │ │ │ ├── DashboardView.java | ||
| │ │ │ └── component/ | ||
| │ │ ├── settings/ | ||
| │ │ │ ├── SettingsController.java | ||
| │ │ │ ├── SettingsModel.java | ||
| │ │ │ ├── SettingsView.java | ||
| │ │ │ └── component/ | ||
| │ │ └── package-manager/ | ||
| │ │ ├── PackageManagerController.java | ||
| │ │ ├── PackageManagerModel.java | ||
| │ │ ├── PackageManagerView.java | ||
| │ │ and component/ | ||
| │ ├── component/ # Shared generic components (Button, Table, Dialog, etc.) | ||
| │ ├── util/ # UI utilities (bindings, converters, CSS helpers) | ||
| │ └── event/ # Event bus and custom events |
Contributor
Author
There was a problem hiding this comment.
This is a recommended structure that I still need some feedback on.
…ing-to-ui-components-clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2110
Implemented changes:
Testing instructions
No testing possible, as this is only a documentation update.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal