#1165: fix eclipse automatic project import

[Ali-Shariati-Najafabadi]

This PR fixes #1165

Implemented changes:

• Reordered the arguments passed to eclipse for importRepository so -application/-buildfile come before -vmargs. Everything after -vmargs is forwarded to the JVM instead of being parsed by eclipse itself, so -application org.eclipse.ant.core.antRunner was never seen by eclipse and it silently fell back to launching the normal GUI instead of running the headless ant import.
• Fixed a property key mismatch: the Java side passed -DrepositoryImportPath=... but eclipse-import.groovy read it back via antProperties.get("devonImportPath") (leftover from an incomplete rename), so the import path was never picked up.

---

Testing instructions

1. Configure a repository with import=eclipse in your settings repository (see repository.adoc).
2. Run ide create <project> <settings-git-url> (or ide repository on an existing project).
3. Verify the project import into eclipse runs headlessly in the background without popping up the eclipse GUI and without requiring you to close anything manually.
4. Alternatively run mvn -Dtest=EclipseTest test in the cli module, which covers the fix with EclipseTest#testImportRepository.

---

Checklist for this PR

• When running mvn clean test locally all tests pass and build is successful
• PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
• PR top-level comment summaries what has been done and contains link to addressed issue(s)
• PR and issue(s) have suitable labels
• Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
• You followed all coding conventions
• You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
  with internal
• You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
• You have formulated clear instructions on how to test your contribution under "Testing instructions"

[coveralls]

Coverage Report for CI Build 31711941828

Warning

No base build found for commit 31dabbf on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 72.916%

Details

• Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →

---

Coverage Stats

Relevant Lines:	17549
Covered Lines:	13346
Line Coverage:	76.05%
Relevant Branches:	7757
Covered Branches:	5106
Branch Coverage:	65.82%
Branches in Coverage %:	Yes
Coverage Strength:	3.23 hits per line

---

💛 - Coveralls

[Hiepiscus]

@Ali-Shariati-Najafabadi Thanks for the PR. I followed the test instructions using a local repository configuration with import=eclipse.

During the setup, I got the following Eclipse error dialog:

After closing the dialog, the setup continued and eventually reported: Successfully ended step 'Setup of repository test-eclipse'.

I am not sure whether this is related to the changes in this PR or to my local Eclipse setup, but I wanted to mention it as part of my testing. I also did not see the Eclipse IDE window being launched during the import.

[hohwille]

@Ali-Shariati-Najafabadi I never took the time to analyse what was going wrong here but your PR now opened my eyes and all seems to make sense. Great that you were able to trace this down and make this work again. 👍

I have one remark that should be addressed, then we can merge.

[Ali-Shariati-Najafabadi]

@Ali-Shariati-Najafabadi Thanks for the PR. I followed the test instructions using a local repository configuration with import=eclipse.

During the setup, I got the following Eclipse error dialog:

After closing the dialog, the setup continued and eventually reported: Successfully ended step 'Setup of repository test-eclipse'.

I am not sure whether this is related to the changes in this PR or to my local Eclipse setup, but I wanted to mention it as part of my testing. I also did not see the Eclipse IDE window being launched during the import.

Thanks for testing! Good news: the actual #1165 bug is fixed and no GUI popup, import finished fine.
That dialog is something else though. could you send me the .metadata.log it mentions?

[Hiepiscus]

I reviewed the .metadata log file and found that the /_ide/internal/eclipse-import.groovy file was missing. After adding it to the directory, it works now. Thanks!