Skip to content

fix(sharing-dialog): add keyboard navigation to autocomplete - #1762

Open
ericcowan wants to merge 1 commit into
dhis2:masterfrom
ericcowan:LIBS-571/sharing-dialog-keyboard-navigation
Open

ericcowan wants to merge 1 commit into
dhis2:masterfrom
ericcowan:LIBS-571/sharing-dialog-keyboard-navigation

Conversation

@ericcowan

@ericcowan ericcowan commented Aug 28, 2026

Copy link
Copy Markdown

Summary

  • allow ArrowDown from the SharingDialog autocomplete input to move focus into the results menu
  • reuse the menu's existing arrow-key navigation and Enter selection behavior
  • add regression coverage for moving into the menu, navigating down/up, and selecting a result

Why

The User or group autocomplete exposes matching results visually, but keyboard users cannot move focus from the search input into those results. This change provides that missing entry point without replacing the menu's existing keyboard behavior.

Keyboard sequence covered by the test: ArrowDownArrowDownArrowUpEnter.

Verification

  • SharingDialog tests: 6 suites passed, 40 tests passed, 7 snapshots passed
  • package build completed successfully
  • changed files pass the repository's ESLint and Prettier checks
  • git diff --check is clean

Jira: LIBS-571

Related to #1447

@ericcowan
ericcowan requested a review from a team as a code owner August 28, 2026 14:11
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant