Skip to content

fix(watch): reload compose config before rebuild#13858

Closed
maxpetrusenkoagent wants to merge 1 commit into
docker:mainfrom
maxpetrusenkoagent:hermes/oss-pr-2026-06-20-docker-compose-11003
Closed

fix(watch): reload compose config before rebuild#13858
maxpetrusenkoagent wants to merge 1 commit into
docker:mainfrom
maxpetrusenkoagent:hermes/oss-pr-2026-06-20-docker-compose-11003

Conversation

@maxpetrusenkoagent

Copy link
Copy Markdown

Summary

  • reload the Compose project before a watch rebuild recreates services
  • preserve existing watch rebuild behavior while using current compose/env_file data
  • add unit coverage for reloading project config and an e2e regression for updated env_file values

Fixes #11003

Test plan

  • go test ./pkg/compose -run TestProjectForRebuildReloadsLatestConfig -count=1 -v
  • go test ./pkg/compose -run 'TestProjectForRebuildReloadsLatestConfig|TestWatch_Sync' -count=1 -v
  • go test ./pkg/compose -count=1
  • go test ./cmd/compose -count=1
  • go test ./pkg/api ./pkg/compose ./cmd/compose -count=1
  • go test -tags e2e ./pkg/e2e -run TestWatchRebuildUsesLatestProjectConfig -count=1 -v could not complete locally because Docker is not running: failed to connect to the docker API at unix:///var/run/docker.sock
  • golangci-lint run --build-tags "e2e" ./cmd/compose ./pkg/api ./pkg/compose ./pkg/e2e could not run locally because golangci-lint is not installed
  • make lint could not run locally because this Docker CLI has no docker buildx command

Signed-off-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com>
@glours

glours commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Closing this. This is low-quality, agent-generated AI slop that adds no value, issue is already tracked, and the changes are unverified and in several cases plain wrong. Not reviewing PRs like these.

@glours glours closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] docker compose alpha watch does not recreate container with current config if config changes while command is running.

2 participants