Repository navigation
Add metrics, drift repair, completion taints and AWS IPAM - #179
Merged
Merged
Conversation
mthorson
marked this pull request as ready for review
October 14, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional assignment labels, metrics, GCP drift repair, completion taints and AWS IPAM allocation. New behavior defaults off. This draft includes the assignment-label change from #178 and should merge after it.
Node state writes verify UID and resource version. Persistent assignment modes require release disabled and Node patch permission. Completion cannot be combined with drift repair or IPAM. AllocateAddress disables SDK retries because it has no idempotency token; uncertain outcomes recover by tags or require explicit reconciliation. Association failures retain the reservation.
GCP operation-status reads retry transient transport errors without repeating mutations. AWS release retries transient InvalidIPAddress.InUse after disassociation, and IPAM recovery supports a primary interface without an existing public IP. Deployment guidance covers required IAM actions and independent API connectivity. Shutdown grace is 330 seconds to cover the five-minute release timeout.
Validation: full race-enabled Go tests, lint and CI passed for the runtime changes. Live GCP and AWS checks covered assignment, restart recovery, ownership refusal, permission failures, release, metrics, drift repair and completion-state behavior. The injected lost-allocation-response case used real AWS allocation and verified no duplicate allocation. No merge or release has been performed.