Repository navigation
feat(rpcclient): pass the request message to rpc_call - #458
Merged
Merged
Conversation
exists() is an async method, so without await the assertion always passed, even when the file didn't exist.
rpc_call now takes the request message itself, e.g. rpc_call(RequestDlopen(filename=..., mode=...)), instead of a msg_id and the request's fields. The msg_id and reply type come from the request's .proto file (MsgId.REQ_X and ReplyX), so messages from other .proto files work without registering them.
rpc_call no longer uses it, so remove it along with RpcBridge's messages parameter.
doronz88
approved these changes
Nov 15, 2026
A reply that doesn't answer the request means the stream is out of step with the server, so every later call would read the previous call's reply. Raise UnexpectedReplyError instead of a bare ValueError and close the connection, as is done for a ConnectionError.
The generated *_pb2.py files refuse to load on an older runtime (ValidateProtobufRuntimeVersion), so state that in the dependencies.
doronz88
force-pushed
the
feat/rpc-call-message
branch
from
November 16, 2026 10:51
d2baa99 to
f4a191c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpc_calltakes the request message itself:rpc_call(RequestDlopen(filename=..., mode=...))instead ofrpc_call(MsgId.REQ_DLOPEN, filename=..., mode=...).MsgId.REQ_XandReplyX), so messages from other .proto files work without registering them.RpcMessageRegistryandRpcBridge'smessagesparameter.test_push_pull_dir, which asserted onRemotePath.exists()without awaiting it.No wire protocol or server changes.
Breaking changes
rpc_call(msg_id, **kwargs)is replaced byrpc_call(request).RpcMessageRegistryand themessagesparameter ofRpcBridge/RpcBridge.connectare removed.Testing
tests/test_rpc_call.py.test_dns_cacheandtest_dns_delete(markedlocal_only), because the macOS server build isn't signed with the mDNSResponder entitlement. That's unrelated to this change