Avoid unresolved runtime token warnings in log publishing - #17320
Open
akoeplinger wants to merge 2 commits into
Open
Avoid unresolved runtime token warnings in log publishing#17320akoeplinger wants to merge 2 commits into
akoeplinger wants to merge 2 commits into
Conversation
Conditionally include internal runtime feed arguments in the publish-logs template. Preserve the existing internal default and opt out callers that do not generate the runtime SAS token. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d161c906-d626-4654-accd-0ae750b202b3
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Arcade’s Azure Pipelines log-publishing template to avoid passing internal runtime feed arguments in scenarios where the internal runtime SAS token isn’t available, reducing unresolved-variable noise and avoiding potential failures during log redaction.
Changes:
- Added an
enableInternalRuntimesswitch to the corepublish-logssteps template and used it to include/exclude internal runtime feed arguments. - Updated the publishing-v3 pipeline to opt out of internal runtime feed arguments when publishing logs.
- Updated the signing validation post-build stage to opt out of internal runtime feed arguments when publishing logs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/publishing/v3/publish.yml | Passes enableInternalRuntimes: false to the publish-logs step template for the assets publishing job. |
| eng/common/core-templates/steps/publish-logs.yml | Adds enableInternalRuntimes parameter and conditionally includes internal runtime feed arguments for the redaction step. |
| eng/common/core-templates/post-build/post-build.yml | Passes enableInternalRuntimes: false for the signing validation stage’s publish-logs invocation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableInternalRuntimesswitch to the publish-logs templateValidation
git diff --check