[release/8.0.1xx] Go back to using PATs for VMR sync - #20937
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the VMR synchronization pipeline to use a classic PAT for pushing to dotnet/dotnet again (instead of minting a GitHub App installation token), and adjusts the GitHub App token minting script’s Key Vault signing and installation selection logic.
Changes:
- Switch VMR sync push authentication back to a PAT sourced from the
DotNetBot-GitHubvariable group. - Remove the GitHub App token acquisition step/workaround from the VMR synchronization job.
- Update
Get-GitHubAppToken.ps1to use the Key Vaultsignresponsevaluefield and tighten installation enumeration/selection behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/vmr-synchronization.yml | Removes GitHub App token minting steps and uses a bot PAT for darc vmr push to the public VMR. |
| eng/common/Get-GitHubAppToken.ps1 | Updates Key Vault signing output parsing and improves GitHub App installation paging and selection checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
74
to
83
| Write-Host "Signing JWT with key '$KeyName' in vault '$KeyVaultName'..." | ||
| $previousNativeCommandErrorPreference = $PSNativeCommandUseErrorActionPreference | ||
| try { | ||
| # Azure CLI can emit non-fatal Python warnings to stderr even when signing succeeds. | ||
| # Use the exit code to determine success for this invocation. | ||
| $PSNativeCommandUseErrorActionPreference = $false | ||
| $signatureBase64 = az keyvault key sign ` | ||
| $signatureUrl = az keyvault key sign ` | ||
| --vault-name $KeyVaultName ` | ||
| --name $KeyName ` | ||
| --algorithm RS256 ` | ||
| --digest $digestBase64 ` | ||
| --query signature ` | ||
| --query value ` | ||
| --output tsv ` | ||
| --only-show-errors |
premun
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.