Repository navigation
feat!: replace unit error types with typed errors - #51
Merged
Merged
Conversation
- Add srad_client::ClientError and return it from Client methods - Propagate client errors through srad-app and srad-eon - Add BdseqError, MessageMetricError and MessageMetricsError - Add DataTypeError, QualityError, Property/PropertySet errors - Propagate typed template conversion errors through srad-macros - Remove remaining Result<_, ()> error types and add coverage
Wrap the underlying boxed error instead of exposing channel/queue variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the remaining
Result<_, ()>error types with typed errors across the client, app, edge-node, and types crates.This is a breaking change for the affected public APIs.
Client
srad_client::ClientErrorwrappingBox<dyn Error + Send + Sync>.ClientErrorfrom allClientmethods.DynClientobject-safe by using a single concrete error type.rumqttcerrors intoClientErrorwithout exposing backend-specific variants.App
AppClientpublish methods now returnClientError.BdseqErrorfor missing, invalid, and out-of-range BDSEQ values.PayloadError::InvalidBdseqnow carries the underlyingBdseqError.InvalidBdseq/MissingTimestampmessages.EoN
PublishError::Clientand propagate client failures instead of masking them asStateError::Offline.node_birthnow returnsPublishErrorand logs the actual failure.MessageMetricErrorandMessageMetricsError.Types
DataTypeError,QualityError,PropertyValueError, andPropertySetError.PropertySet::insertreportsReservedQuality.TemplateError::MissingValueandTemplateError::ValueConversion.