Repository navigation
Conversation
The test edited shots/a.txt after the pass had renamed the folder to Shots. On a case-insensitive disk that's the same file, but on a case-sensitive one it's a new folder, so the test failed on Linux. CONTRIBUTING.md and AGENTS.md say how to run the tests on a case-sensitive disk with TMPDIR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before
"syncs an edit made after the scan to a file in a folder renamed in case only" edited
shots/a.txtafter the pass had renamed the folder toShots. On a case-insensitive disk that's the same file. On a case-sensitive disk, like Linux's, it created a secondshots/folder, so the test failed withexpected 'A' to be 'edited after the scan'.After
The test writes to
Shots/a.txt, the folder's real name, so it passes on both kinds of disk. CONTRIBUTING.md and AGENTS.md say how to run the tests on a case-sensitive disk. Tests make their temp folders underTMPDIR, so on a Mac it'sTMPDIR=/Volumes/<case-sensitive volume> npm test.A project with both
shots/andShots/on a case-sensitive disk isn't tested yet. It needs a sync decision first.Test plan
npm test, 293 passed.TMPDIR:mainfails this test the same way Linux does. With this change, 293 passed./tmp): 292 passed, 1 skipped (a macOS-only Unicode test).