Repository navigation
[#300] Fix for raster initialization code used in sinmap python scripts - #301
Merged
Merged
Conversation
pkdash
marked this pull request as ready for review
May 19, 2026 02:22
Collaborator
Author
|
@dtarb Let me know if you want to review this. I want to include this in release 5.5.0 for which I have already created a draft release few weeks back. |
dtarb
reviewed
May 19, 2026
| # Set projection from the source raster without reparsing WKT because | ||
| # some ArcGIS binary DEM projections can fail ImportFromWkt with corrupt data errors. | ||
| source_srs = base_raster.GetSpatialRef() if hasattr(base_raster, 'GetSpatialRef') else None | ||
| if source_srs: |
Owner
There was a problem hiding this comment.
Why not do the else option all the time?
Collaborator
Author
There was a problem hiding this comment.
I added comments to the this code block to clarify the branching logic.
Owner
|
It is still a bit confusing to me, but I'll take your word for it and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.