GLSP-1786: Remove duplicate standalone Go to menu - #29
Merged
Merged
Conversation
- Add workflow node navigation items to the built-in Go to menu so the standalone example presents one navigation submenu - Remove duplicate marker items and the now-unused marker traversal helper from the example closes eclipse-glsp/glsp#1786
Contributor
|
Previews removed, the pull request is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Follow-up to #28: the standalone workflow example still provided its own marker items and Go To submenu, causing two navigation submenus after the built-in provider was fixed.
parentId: 'navigate'.Fixes eclipse-glsp/glsp#1786
How to test
pnpm build,pnpm lint:fix,pnpm format,pnpm headers:fix -t changes, andpnpm test(1,631 tests passed).pnpm e2e test:standalone-browser(73 tests passed).Follow-ups
None.
Changelog