Migrate PR previews to the shared glsp-previews repository - #111
Merged
Merged
Conversation
Previews now live in eclipse-glsp/glsp-previews next to the glsp-core demos, so no deployment flow of this repository needs write access to it anymore. The build stays in an untrusted context and only the deploy holds the token, which is scoped to the previews repository alone. - pr-preview-build: build with the previews repository as Hugo base URL and drop the PR metadata artifact; the deploy workflow resolves the pull request itself, which also covers forks - pr-preview-deploy: push to the shared previews branch and track the deployment in a sticky comment that reports the pending, failed and deployed state next to the live website - pr-preview-remove: remove the preview from the shared branch instead of the local gh-pages branch - Skip previews for changes that cannot affect the built website (README, LICENSE, .vscode, .devcontainer) - Remove gh-pages-cleanup; the previews repository prunes stale previews and squashes its history for all publishing repositories - Document both deployment flows in the README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previews now live in eclipse-glsp/glsp-previews next to the glsp-core demos, so no deployment flow of this repository needs write access to it anymore. The build stays in an untrusted context and only the deploy holds the token, which is scoped to the previews repository alone.