Skip to content

GLSP-1682: Repoint stale links to glsp-core - #113

Merged
tortmayr merged 1 commit into
masterfrom
glsp-1682-core-links
Sep 18, 2026
Merged

tortmayr merged 1 commit into
masterfrom
glsp-1682-core-links

Conversation

@tortmayr

@tortmayr tortmayr commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

What it does

The GLSP-1682 consolidation moved glsp-client and glsp-server-node into
eclipse-glsp/glsp-core. The website still linked the old repos exclusively
and did not mention glsp-core at all.

  • Repoint ~30 stale links to glsp-core, accounting for the changed package
    layout (client/client, common/protocol, server/server, server/graph,
    server/server-mcp)
  • Replace the SHA-pinned tool-palette link with one to main, and adapt the
    prose: the palette now opens in postRequestModel, not preRequestModel
  • Introduce glsp-core on the landing page as the consolidated home of client,
    Node server, protocol and shared tooling

Also:

  • Point the Protocol card at our own protocol docs, since PROTOCOL.md in the
    umbrella repo is now just a stub redirecting here
  • Fix two pre-existing mis-targeted links (standalone example, tool palette)

Links to eclipse-glsp/glsp for issues, discussions and PROTOCOL.md are
left untouched.

Part of: eclipse-glsp/glsp#1682

How to test

  • grep -rn 'glsp-client\|glsp-server-node' content/ — remaining hits are
    prose about the adopter's own your-glsp-client package
  • All 23 unique link targets verified to exist on glsp-core main

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Rewrite all deep links into glsp-client, glsp-server-node and their
  packages to their new home in glsp-core, accounting for the changed
  package layout (client/client, common/protocol, server/server,
  server/graph, server/server-mcp)
- Apply a consistent link depth: landing-page component and integration
  cards point at the group directory (packages/client, packages/server),
  documentation prose at the concrete package it describes
- Replace the SHA-pinned tool-palette link with a link to main and adapt
  the surrounding prose: the palette is now opened in the
  'postRequestModel' startup hook, not 'preRequestModel'
- Introduce glsp-core on the landing page as the consolidated home of
  client, Node server, protocol and shared tooling, and link the Node
  server framework and the protocol sources from the component cards
- Point the workflow standalone example at examples/workflow-standalone
  in glsp-core, which also fixes the pre-existing wrong link to
  glsp-theia-integration

Also:
- Point the Protocol card at the site's own protocol documentation, since
  PROTOCOL.md in the umbrella repo is now only a stub redirecting here
- Link the tool palette UI extension in the ui-extensions bullet list to
  its implementation instead of the protocol action definitions, matching
  the sibling Sprotty bullets
- Use the canonical glsp-website-source URL for the documentation
  repository instead of relying on the eclipsesource redirect

Part of: eclipse-glsp/glsp#1682
@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Website preview removed, the pull request is closed.

@tortmayr
tortmayr merged commit 7a2231d into master Sep 18, 2026
2 checks passed
@tortmayr
tortmayr deleted the glsp-1682-core-links branch September 18, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants