Repository navigation
fix: crash in postMessageHandler on message without source - #172
Merged
Merged
Conversation
Gracefully handle the case where the incoming message source is null. For sarc-acl/sokatoa-internal#4882 Signed-off-by: Christian W. Damus <cdamus@eclipsesource.com>
colin-grant-work
approved these changes
Jun 11, 2026
colin-grant-work
left a comment
colin-grant-work
left a comment
Collaborator
There was a problem hiding this comment.
The fix looks correct; I'm curious if we know why the sourceless message is being sent, but only under specific conditions?
ALevansSamsung
approved these changes
Jun 11, 2026
Collaborator
Author
I don't know what this message is. According to my research the most likely origin of such a message is something internal to the browser, not a "normal" message sent by the application or in response to any user action. I suspect that it's something specific to the Linux implementation of Chromium or Electron as I am unable to reproduce the message on Mac, not even with the packaged Electron app bundle and trying to launch second instances. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gracefully handle the case where the incoming message source is null.
For android-graphics/sokatoa#4882