Repository navigation
ui: log when a track is registered but never added to the track tree - #174
Merged
Merged
Conversation
A track that is registered but never added to the track tree fails silently in two ways that are easy to mistake for missing trace data: it is not drawn, and links to it from other tracks (e.g. from a CPU scheduling slice to the thread's state track) resolve through the track registry and then have nowhere to scroll to. Both `addChildInOrder()` call sites that can lose a track this way discarded the group lookup and the returned Result, so neither reported anything. Check both, and warn when a thread group has no process group to live in or a thread state track has no thread group. Also order the thread state track query explicitly. The order in which those tracks are registered and inserted into their groups was whatever SQLite happened to return, which makes their order in the timeline vary from run to run. For sarc-acl/sokatoa-internal#5569 Signed-off-by: Christian W. Damus <cdamus@eclipsesource.com>
Collaborator
Author
|
Merging as approved from consuming application side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A track that is registered but never added to the track tree fails silently in two ways that are easy to mistake for missing trace data: it is not drawn, and links to it from other tracks (e.g. from a CPU scheduling slice to the thread's state track) resolve through the track registry and then have nowhere to scroll to. Both
addChildInOrder()call sites that can lose a track this way discarded the group lookup and the returned Result, so neither reported anything.Check both, and warn when a thread group has no process group to live in or a thread state track has no thread group.
Also order the thread state track query explicitly. The order in which those tracks are registered and inserted into their groups was whatever SQLite happened to return, which makes their order in the timeline vary from run to run.
For android-graphics/sokatoa#5569