Fix escaped Jinja delimiters split across Word runs - #662
Open
CAOShurong wants to merge 1 commit into
Open
Conversation
Join only the four supported escaped Jinja delimiter tokens when Word has divided their characters into separate runs. Keep matching within one paragraph and add regression coverage for single-run, split-run, and false-positive cases. Assisted-by: OpenAI Codex <noreply@openai.com> Signed-off-by: CAOShurong <170531907+CAOShurong@users.noreply.github.com>
ahmetmusab42-stack
approved these changes
Sep 1, 2026
ahmetmusab42-stack
left a comment
There was a problem hiding this comment.
Tested exact head a8290b9 independently.
- Reproduced #548 with the original attached DOCX:
masterleaves the four split-run escaped delimiters unchanged, while this branch renders all four as{%,%},{{, and}}. - Ran the new regression test successfully on Python 3.12 and 3.13.
- Exercised all four delimiters across both possible paragraph-boundary splits (8 raw OOXML cases); none were joined across
w:pboundaries. - Confirmed the two non-delimiter examples remain unchanged.
- Ran the standalone test scripts, flake8,
uv build, and a separate exact-venv CLI render; all relevant checks passed. (The existingmodule_execute.pyrunner caveat is unrelated and already tracked by #652.)
The change is focused, fixes the reported document, and I did not find a blocking issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #548.
Problem
Jinja's escaped delimiters (
{_{,}_},{_%,%_}) render correctly when all three characters are in one Word run. When Word splits those characters across separate<w:r>elements, the run markup remains between them and the final delimiter replacement never sees a contiguous token.Fix
{a_{helloand{f_{) unchanged.Verification
masterfixed the four single-run examples but left all four split-run examples escaped.{%,%},{{, and}}as intended.masterand passes on this branch.flake8 . --count --max-line-length=127 --show-source --statistics: 0 findings.OpenAI Codex assisted with reproduction, implementation, and test execution. I reviewed the diff and all reported results before submitting.