Repository navigation
Skip release notes checks on draft pull requests - #4611
Merged
Merged
Conversation
Draft PRs get a failed release notes check and a "Changelog labels needed" comment before the author is ready. skip-drafts skips both on drafts. The ready_for_review event runs the checks when the PR is ready, and converted_to_draft clears a failed check when a PR goes back to draft. Needs elastic/docs-actions#442 in docs-actions v1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0198Z15QXfthJ2QgGztrDHtu
![infra-vault-gh-plugin-prod[bot]](https://avatars.githubusercontent.com/u/6764390?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft pull requests in this repository no longer get the release notes check or its pull request comment. The check runs when the pull request is marked ready for review.
Affects: Automation
Prompt summary: A Kibana engineer asked to stop the "Changelog labels needed" comment on draft pull requests. The fix is an opt-in
skip-draftsinput indocs-actions, and each repository that uses the release notes caller opts in. This pull request opts docs-builder in.Why
release-notes / validateruns on every pull request, drafts included. A draft without a type label gets a failed check and a comment before the author is ready.What
Drafts skip the check
The caller sets
skip-drafts: true, so a draft shows the check as skipped and gets no comment. GitHub cannot merge a draft, so a skipped check never lets a pull request through.The check follows draft transitions
The caller listens for
ready_for_review, so the check runs as soon as a pull request leaves draft. It also listens forconverted_to_draft, so a failed check turns into a skipped one when a pull request goes back to draft.Depends on: elastic/docs-actions#442, released in
docs-actions1.69.0.v1declares theskip-draftsinput.Out of scope: #4610 collapses the label tables in the same comment. The two changes are independent.
Generated by Claude Code