Skip to content

Wrap long get-started commands instead of clipping them #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leemthompo merged 1 commit into from
Oct 29, 2026
Merged

Wrap long get-started commands instead of clipping them #4623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Elastic.Documentation.Site/Assets/markdown/hub.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,20 +228,21 @@
--code-size: var(--text-xs);
--code-leading: 1.2;
}
/* A long command scrolls sideways inside its box instead of being clipped. */
/* A long command wraps inside its box, so the whole command stays visible.
The box keeps the option button's height for a one-line command. */
.hub-get-started .hub-get-started-install pre {
display: flex;
align-items: center;
box-sizing: border-box;
height: 37px;
min-height: 37px;
margin: 0;
padding: 0 36px 0 12px;
overflow-x: auto;
padding: 8px 36px 8px 12px;
background: var(--color-ink-navy);
border-radius: 8px;
}
.hub-get-started .hub-get-started-install code {
white-space: nowrap;
white-space: pre-wrap;
overflow-wrap: anywhere;
Comment on lines +244 to +245

@infra-vault-gh-plugin-prod infra-vault-gh-plugin-prod Bot Oct 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: P3 (Low)

The wrapping fix has no automated layout regression coverage. The existing get-started option tests only check emitted HTML, so they would still pass if commands became clipped again. Add a browser-level case with a long command and an unbroken URL in a constrained column, plus a short-command control that verifies the 37px height.

Generated by Libra. React with 👍 or 👎 to give feedback on this comment.

@leemthompo leemthompo Oct 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No existing browser-level layout test harness to extend here, so I'll leave this to the visual checks rather than add one for a single CSS rule.

}

.hub-get-started .hub-get-started-track {
Expand Down
Loading