Repository navigation
Conversation
A PR that only touches `.libra/`, `CODEOWNERS` or similar files still runs the full build, smoke tests and assembler preview. A new `changes.yml` reports whether a PR touches anything beyond that metadata, and the slow workflows gate on it. The matrix checks that branch protection requires gate per step, so they still report. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ilter The assembler preview now has two jobs, so zizmor flags its workflow-level write permissions. They move to the `build` job. The zizmor path filter also covers `action.yml` and `actions/`, which zizmor audits. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
`ci.yml` already had an inline `changes` job with per-area filters, and the new `scope` check duplicated that mechanism. `changes.yml` now holds every filter, and the three workflows call it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The filters become glob lists that `tj-actions/changed-files` evaluates, the same action `docs-preview-local.yml` already pins. The workflow no longer needs a checkout on pull requests. Callers grant `pull-requests: read` for the API diff. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
`changed-files` reports only a rename's destination by default. Moving a file out of a lambda's inputs, or into `.libra/`, then skipped builds the old `git diff --no-renames` filter would have run. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The `code` filter lists the metadata paths and reads `only_modified` instead of negating them from `**`. The shared build inputs are one anchor reused by both lambda filters, and job outputs compute their values inline, which removes the shell step. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The assembler preview and the docs preview each carried their own copy of the deployment bookkeeping, the S3 sync with CloudFront invalidation, and the closed-PR cleanup. These become `deployment-start`, `deployment-finish` and `upload-preview` composite actions plus a reusable `preview-cleanup.yml`. The docs preview ignore list is defined once, and the assembler preview drops a `setup-node` step that `bootstrap` already ran. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
# Conflicts: # .github/workflows/docs-preview-local.yml
`preview-cleanup.yml` looks deployments up by the task `<environment>-<pr number>`, while the two callers of `deployment-start` spelled that name out by hand. The action now takes a `pr-number` input and builds the task itself, so the name cannot drift between the three files. `assembler-preview-cleanup.yml` loses its `workflow_call` trigger: no repository calls it, and a nested `$/` reference would not resolve for an external caller. The unused `deployment_result` output in `docs-preview-local.yml` goes too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Throwaway change for the verification run of #4619. The PR closes without merging. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4625/ Sample changed pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway draft PR that exercises the shared preview steps from #4619 against
main, because the docs preview only deploys for PRs whose base is a content source branch. It is closed without merging once both previews deploy.Affects: Deploys & previews
Why
#4619 moves the deployment, upload and cleanup steps into shared actions. Its own runs skipped the docs preview because nothing under
docs/changed, and a draft against the feature branch (#4624) skipped it too becauseassembler-matchonly matchesmain.What
A docs change on top of the feature branch
One paragraph appended to
docs/development/essc.md, which makes the docs preview build and upload through the new composites in the merge commit. The assembler preview runs on every PR regardless.Verify
Both previews report a deployment status on this PR.
🤖 Generated with Claude Code