[CI] SearchSourceBuilderTests testSupportsParallelCollection failing #163337

Activity

1. infra-vault-gh-plugin-prod

   added

   >test-failureTriaged test failures from CITriaged test failures from CI

   :Search Foundations/SearchCatch all for Search FoundationsCatch all for Search Foundations

   on Oct 26, 2026
2. elasticsearchmachine

   added

   needs:riskRequires assignment of a risk label (low, medium, blocker)Requires assignment of a risk label (low, medium, blocker)

   Team:Search FoundationsMeta label for the Search Foundations team in ElasticsearchMeta label for the Search Foundations team in Elasticsearch

   on Oct 26, 2026
3. elasticsearchmachine commented on Oct 26, 2026

   

   elasticsearchmachine

   on Oct 26, 2026

   Collaborator

   More actions

   Pinging @elastic/es-search-infra (Team:Search Foundations)
4. github-actions

   added a commit that references this issue on Oct 26, 2026

   Mute org.elasticsearch.search.builder.SearchSourceBuilderTests testSu…

   ...

   7f8cd1c
5. infra-vault-gh-plugin-prod commented on Oct 26, 2026

   

   infra-vault-gh-plugin-prodBot

   on Oct 26, 2026

   ContributorAuthor

   More actions

   This has been muted on branch main

   Mute Reasons:

   • [main] 1 consecutive failures in test testSupportsParallelCollection
   • [main] 1 consecutive failures in step ubuntu-2404_platform-support-unix
   • [main] 1 consecutive failures in pipeline elasticsearch-periodic-platform-support

   Muted tasks:

   • :server:test

   Build Scans:

   • elasticsearch-periodic-platform-support #12938 / ubuntu-2404_platform-support-unix
6. elasticsearchmachine commented on Oct 26, 2026

   

   elasticsearchmachine

   on Oct 26, 2026

   Collaborator

   More actions

   Test Failure Analysis

   Summary

   • SearchSourceBuilderTests generates random suggest builders via PhraseSuggestionBuilderTests.randomPhraseSuggestionBuilder(), which calls maybeSet(testBuilder::realWordErrorLikelihood, randomFloat()). randomFloat() can return exactly 0.0, and PhraseSuggestionBuilder.realWordErrorLikelihood rejects <= 0.0 with real_word_error_likelihood must be > 0.0.
   • The sibling line for maxErrors was already guarded with Math.max(randomFloat(), Float.MIN_NORMAL). realWordErrorLikelihood was missed. This is a test-data bug, not a production bug.

   Release risk: low-risk

   The failure is a rare random-value edge case (0.0 float) in test generation. Production validation behaves as designed. It would only change if the production setter were also hit by real inputs, which isn't indicated.

   Impact

   • Affected branches: main
   • Affected OS: ubuntu-2404
   • Affected pipelines: elasticsearch-periodic-platform-support
   • Trend: single occurrence (1 consecutive failure), seed-dependent

   Reproduction

   • Command: ./gradlew ":server:test" --tests "org.elasticsearch.search.builder.SearchSourceBuilderTests.testSupportsParallelCollection" -Dtests.seed=611D4D0204011623 -Dtests.locale=so-KE -Dtests.timezone=America/Caracas -Druntime.java=27
   • Commit: 4fcc683
   • Remote job: https://buildkite.com/elastic/elasticsearch-agentic-workflow/builds/2004 (ubuntu-2404)
   • Result: not reproduced (passed with the same seed; the original seed likely depended on the full-suite random sequence or on a different JDK 27 build)
   • Build scan: https://gradle-enterprise.elastic.co/s/tfyof73o7cqkw

   Mitigation Proposal

   • Reproduction verdict: not reproduced, so confidence rests on code inspection. The exception text matches the setter exactly, and the maxErrors line shows this class of bug was fixed before.
   • Codebase investigation: server/src/test/.../suggest/phrase/PhraseSuggestionBuilderTests.java:39 and PhraseSuggestionBuilder.java:248-252. The confidence setter on the next line may need a similar check, so verify it.
   • Recent git history: not inspected (the shared git mirror was unreadable).
   • Proposed fix: change line 39 to maybeSet(testBuilder::realWordErrorLikelihood, Math.max(randomFloat(), Float.MIN_NORMAL));. Validate by running :server:test --tests "*PhraseSuggestionBuilderTests" --tests "*SearchSourceBuilderTests" a few hundred times, then remove the muted-tests.yml entry for SearchSourceBuilderTests.testSupportsParallelCollection.
   • Effort estimate: trivial — a one-line test change.
   • Confidence: 0.80 (high) — the exception message matches the generator exactly. The gap is that the failing seed did not reproduce.

   ---

   Generated by test-analysis · archimedes v1.3.0 · openrouter/anthropic/claude-sonnet-5.5
7. DonalEvans

   self-assigned this

   on Oct 26, 2026
8. DonalEvans

   added

   low-riskAn open issue or test failure that is a low risk to future releasesAn open issue or test failure that is a low risk to future releases

   and removed

   needs:riskRequires assignment of a risk label (low, medium, blocker)Requires assignment of a risk label (low, medium, blocker)

   on Oct 26, 2026
9. DonalEvans

   added a commit that references this issue on Oct 26, 2026

   Prevent invalid random value in PhraseSuggestionBuilderTests

   ...

   This issue will close once commit 17eee4b is merged into the 'main' branch.

   17eee4b
10. DonalEvans

    closed this as completedin #163423on Oct 26, 2026
11. DonalEvans

    added a commit that references this issue on Oct 26, 2026

    Prevent invalid random value in PhraseSuggestionBuilderTests (#163423)

    ...

    This issue will close once commit 749b752 is merged into the 'main' branch.

    749b752
12. elasticsearchmachine commented on Oct 26, 2026

    

    elasticsearchmachine

    on Oct 26, 2026

    Collaborator

    More actions

    Test Analysis Accuracy Review

    Verdict	✅ accurate — overall score 0.95
    Root-cause match	✅ match
    Mitigation match	✅ match
    Release-risk accuracy	✅ accurate
    Predicted	low-risk risk · test_hardening
    Actual fix	test_hardening — #163423

    The analysis correctly identified that PhraseSuggestionBuilderTests.randomPhraseSuggestionBuilder() could generate realWordErrorLikelihood = 0.0 via randomFloat(), matching the sibling maxErrors guard pattern — the merged fix applied exactly the proposed Math.max(randomFloat(), Float.MIN_NORMAL) guard and removed the mute entry.

    ---

    Generated by review-test-analysis · archimedes v1.3.0 · agent-router/claude-sonnet-5
13. elasticsearchmachine

    added 4 commits that reference this issue on Oct 26, 2026

    Prevent invalid random value in PhraseSuggestionBuilderTests (#163423) (

    ...

    This issue will close once commit b2fdeeb is merged into the 'main' branch.

    b2fdeeb

    Prevent invalid random value in PhraseSuggestionBuilderTests (#163423) (

    ...

    This issue will close once commit fea7f96 is merged into the 'main' branch.

    fea7f96

    Prevent invalid random value in PhraseSuggestionBuilderTests (#163423) (

    ...

    This issue will close once commit a0cd8a9 is merged into the 'main' branch.

    a0cd8a9

    Prevent invalid random value in PhraseSuggestionBuilderTests (#163423) (

    ...

    This issue will close once commit ceeb528 is merged into the 'main' branch.

    ceeb528