Repository navigation
fix(trail): deprecate trail resume --repo - #2829
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The focused changes preserve repository and branch safeguards, have regression coverage, and have no identified blocking issues.
No open issues 馃帀
What changed in this PR
Makes trail resume --repo forge-aware so Entire-hosted checkouts accept valid repository assertions and produce usable resume commands.
Changes:
- Accept bare
owner/repoon any forge while keeping explicit forge assertions strict. - Forge-qualify printed repository references and suggest corrected commands for forge-only mismatches.
- Add regression tests for parsing, validation, suggestions, and Entire-hosted output.
| File | Description |
|---|---|
cmd/鈥媏ntire/鈥媍li/鈥媡rail_resume_cmd.go |
Updates repository assertions, output, help, and mismatch suggestions. |
cmd/鈥媏ntire/鈥媍li/鈥媡rail_resume_cmd_test.go |
Tests forge-aware parsing and validation. |
cmd/鈥媏ntire/鈥媍li/鈥媡rail_legacy_cmd_test.go |
Tests corrected commands and Entire-hosted resume behavior. |
Review effort: Balanced
`trail resume --repo` asserted the checkout's repository, but a bare owner/repo was parsed as GitHub, so commands copied for Entire-hosted repositories failed with "targets repository entirehq/entire-api, but the current checkout is entirehq/entire-api". Resume always acts on the local clone and --branch already guards against pasting into the wrong one. The flag is now hidden and ignored, with a deprecation notice on stderr so previously copied commands keep working, and the printed resume and finding commands no longer include it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M5CFQ1GJE5HND02P7Y6DQPCB
gtrrz-victor
force-pushed
the
victor/trail-resume-repo-forge
branch
from
October 20, 2026 11:04
4722709 to
76211a4
Compare
gtrrz-victor
changed the title
The early origin lookup, the repoFullName parameter and the `repo` field of `trail resume --no-resume --json` existed only for the removed --repo assertion. The working contexts already resolve origin themselves, so remove them, rename the builder to buildTrailResumeContext, and drop the test that covered the repo-aware builder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M5CJ0SCVTPK6GZVYEFGHQHBX
Soph
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/1621