Repository navigation
feat: include per-descriptor code and limitName in response dynamic metadata - #1239
Closed
sc0ttbeardsley wants to merge 1 commit into
Closed
sc0ttbeardsley wants to merge 1 commit into
sc0ttbeardsley wants to merge 1 commit into
Conversation
…etadata
Changes to dynamic metadata (RESPONSE_DYNAMIC_METADATA):
- Only built when at least one descriptor is over its limit (breaking change)
- Each descriptor now includes code (OK or OVER_LIMIT) from response status
- Each descriptor now includes limitName (matched limit name, if configured)
Before:
{descriptors: [{entries: [key=val]}], domain: ...}
After (only when over limit):
{descriptors: [{entries: [key=val], code: OVER_LIMIT, limitName: my-rule}], ...}
Signed-off-by: Scott Beardsley <sbeardsley@pinterest.com>
|
+1 this would be very useful, would enable logging the status of individual ratelimit rules in the Envoy Proxy access log. I'm currently maintaining a fork to have this feature and would love to get rid of it. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to dynamic metadata (RESPONSE_DYNAMIC_METADATA):
Before:
After (only when over limit):