You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running this on our mainnet dev canary (dev-bee-storage/bee-1, build 2.8.2-rc1-66a4ec3c). Both fixes behave: WSS now lands on its own label instead of leaking into tcp, and the zero-init gives flat lines instead of gaps. Thanks for the quick turnaround.
One small suggestion: quic and quic-v1 can never be observed, since bee registers only the TCP and websocket transports (libp2p.go:358 and 381-383). Worth keeping the enum cases and the ClassifyTransport branches for the future, but dropping the two from transportLabelValues, which only drives pre-initialisation. If a QUIC transport is ever added the series will appear on first observation anyway. As it stands that's 6 of the 18 series per node that are structurally always zero.
On cardinality more broadly: this takes a node from 2 series to 18, but a bee node already exposes around 1570, so it works out at roughly a 1% increase. No concern from our side. The public label in particular earns its place, as it's the clearest inbound reachability signal we have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Breaking changes
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
#5506
Screenshots (if appropriate):
AI Disclosure