Repository navigation
Conversation
Code-ve
marked this pull request as draft
October 28, 2026 16:55
Code-ve
marked this pull request as ready for review
October 28, 2026 16:56
Author
|
Hi @ptimizeroracle, Just following up on this PR. The changes and relevant tests are ready from my side. Whenever someone gets a chance, I'd appreciate a review and any feedback. Thank you! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1974.
The import of
evidentlyfails with pandas 3.1.0 becauseinfer_dtype_from_object, an internal pandas utility, is no longer available.This change removes the dependency on that private API and introduces a local dtype-inference helper based on
pandas.api.types.pandas_dtypeand NumPy dtype handling. The existingTestColumnsTypelogic now uses this helper at both dtype-inference call sites.Implementation
pandas.core.dtypes.common.infer_dtype_from_objectutility._infer_dtype_typeto handle supported dtype representations, including NumPy types, pandas extension dtypes, and string aliases.Validation
git diff --checkpassed.Scope
The change is limited to dtype inference in
data_integrity_tests.pyand does not intentionally alter the surrounding test behavior.