fix: cap the IRC banner read + add a read deadline (remote DoS) - #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third from the private report, split one-concern-per-PR as you prefer. Same
panic = "abort"/ remote-DoS family as #98 and #99.src/plugins/irc/mod.rs: the banner-read loop accumulates the server's response intoaccumulated_datawith no size cap and no overall read deadline, and only exits on the welcome line (001+Welcome). So a malicious IRC server can either stream unbounded data (OOM) or connect and then stall forever without ever sending that line (a permanent hang of the operator's worker).This bounds the total read time with a single
tokio::time::timeout_atdeadline across the loop, and caps the accumulated banner at 64 KiB.