Skip to content

Report cancelled loads in load metrics - #387

Open
stasimus wants to merge 1 commit into
experimentingfrom
cancelled-load-metrics
Open

Report cancelled loads in load metrics#387
stasimus wants to merge 1 commit into
experimentingfrom
cancelled-load-metrics

Conversation

@stasimus

@stasimus stasimus commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Closes #386.

A load cancelled while running left no trace in cache_load_result and cache_load_time. CacheMetered now reports it with result=cancelled and the time spent until cancellation. CacheMetrics.load takes a LoadResult (success, failure, cancelled); the Boolean overload stays as a deprecated forwarder.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ca045a70-832e-498e-85cd-76d3b4c83c10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@stasimus
stasimus marked this pull request as draft September 3, 2026 12:10

@mr-git mr-git left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, though very hard to review with changes from #369 interleaved.

Shall we try the "Stacked PRs" feature?

@stasimus
stasimus force-pushed the cancelled-load-metrics branch from c59c07d to 82c5161 Compare September 3, 2026 12:19
@mr-git

mr-git commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

hm.. one unit-test is failing...

@stasimus
stasimus marked this pull request as ready for review September 3, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add metrics for cancelled loads

2 participants