Report cancelled loads in load metrics - #387
Open
stasimus wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
stasimus
marked this pull request as draft
September 3, 2026 12:10
stasimus
force-pushed
the
cancelled-load-metrics
branch
from
September 3, 2026 12:19
c59c07d to
82c5161
Compare
mr-git
approved these changes
Sep 3, 2026
Contributor
|
hm.. one unit-test is failing... |
stasimus
marked this pull request as ready for review
September 3, 2026 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386.
A load cancelled while running left no trace in
cache_load_resultandcache_load_time.CacheMeterednow reports it withresult=cancelledand the time spent until cancellation.CacheMetrics.loadtakes aLoadResult(success, failure, cancelled); theBooleanoverload stays as a deprecated forwarder.