Skip to content

Bound clear and release by loadingTimeout - #390

Open
stasimus wants to merge 1 commit into
cancelled-load-metricsfrom
clear-stuck-loads
Open

Bound clear and release by loadingTimeout#390
stasimus wants to merge 1 commit into
cancelled-load-metricsfrom
clear-stuck-loads

Conversation

@stasimus

@stasimus stasimus commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #389, stacked on #369.

LoadingCache.clear now waits for a load in flight for at most loadingTimeout, then completes its deferred with ExpiredError and lets the load release its own value. ExpiringCache passes its effective timeout through, so clear and release no longer hang on a stuck load. Tests for both, docs updated.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: efbbddff-6b96-4432-9e59-e4da66f7455a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@stasimus
stasimus changed the base branch from experimenting to cancelled-load-metrics September 3, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clear and release hang on a stuck load despite loadingTimeout

1 participant