Skip to content

Fix flaky getOrUpdateOpt test - #391

Open
stasimus wants to merge 1 commit into
experimentingfrom
fix-flaky-getOrUpdateOpt
Open

Fix flaky getOrUpdateOpt test#391
stasimus wants to merge 1 commit into
experimentingfrom
fix-flaky-getOrUpdateOpt

Conversation

@stasimus

@stasimus stasimus commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

The second getOrUpdateOpt started via startEnsure could reach the cache after the first load already completed with None and removed the entry, so it did its own load and returned Some(0). Dropped the waiter, same shape as the getOrUpdateOpt1 test. Seen in https://github.com/evolution-gaming/scache/actions/runs/33754583586

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 97ae5e40-e9ae-432c-b846-7a24477a4b21

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant