Skip to content

Fix facility allocated VLANs missing from resource summary/BQM - #458

Merged
kthare10 merged 1 commit into
mainfrom
allocated-vlans
Oct 2, 2026
Merged

kthare10 merged 1 commit into
mainfrom
allocated-vlans

Conversation

@kthare10

@kthare10 kthare10 commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Problem

/portalresources/summary?level=2&force_refresh=true (and the ABQM returned by /resources) never report allocated VLANs for facility ports: allocated_vlans is always null, even when facility slices are active.

Root cause

The two sides use different keys for facility VLAN allocations:

  • Write: broker_simpler_units_policy.py builds the facility interface node_map as {graph}#{bqm_node.get_name()}#{bqm_cp.node_id}#{vlan}, so actor_database stores the components row with node_id = <facility name>.
  • Read: AggregatedBQMPlugin called occupied_vlans(node_id=fac_sliver.node_id, ...). That passes the facility graph node ID (<port_nid>:facility+<name>), which never matches the stored name.

fim_helper.py already queries by facility name (node_id=f_name), which is correct.

Fix

Use fac_sliver.get_name() in both plug_produce_bqm_summary and plug_produce_bqm.

This changes reporting only. VLAN allocation (allocate_ifs) is not affected.

Testing

  • Compile check only so far.
  • After the broker is redeployed, verify that facility ports with active slices show allocated_vlans in the summary endpoint.

occupied_vlans was queried with the facility graph node_id, but the broker policy keys facility VLAN component rows by facility name. Use fac_sliver.get_name() in both the summary and ABQM paths, matching fim_helper.
@kthare10
kthare10 merged commit 6eb430e into main Oct 2, 2026
4 checks passed
@kthare10
kthare10 deleted the allocated-vlans branch October 2, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant