Del using namespace aitemplate/AITemplate/static/include/kernels/mem_eff_attention/kernel_forward.h - #1016
Open
r-barnes wants to merge 1 commit into
Open
Del using namespace aitemplate/AITemplate/static/include/kernels/mem_eff_attention/kernel_forward.h#1016r-barnes wants to merge 1 commit into
r-barnes wants to merge 1 commit into
Conversation
…eff_attention/kernel_forward.h Summary: Removes a `using namespace` from the global namespace in pursuit of enabling `-Wheader-hygiene`. Qualifies instances that relied on the `using namespace`. Differential Revision: D60448278
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60448278 |
RahulVadisetty91
left a comment
RahulVadisetty91
left a comment
There was a problem hiding this comment.
Check the architecture condition and datatype comparison for potential improvement. You might need to modify the condition or adapt it for newer architectures.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes a
using namespacefrom the global namespace in pursuit of enabling-Wheader-hygiene.Qualifies instances that relied on the
using namespace.Differential Revision: D60448278