Repository navigation
ci: start release-please after v0.4.0 for the moved grantry package - #39
Merged
Merged
Conversation
Moving grantry from . to grantry/ lost the link to the v0.4.0 release, so release-please read all of history and applied the old Release-As: 0.2.0 footer of fb23cb4 to both crates. last-release-sha limits it to the commits since v0.4.0. Remove it once grantry 0.5.0 and grantry-redis 0.1.0 are out.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR #38 proposes grantry 0.2.0 and grantry-redis 0.2.0. It should be grantry 0.5.0 and grantry-redis 0.1.0.
Moving grantry from
.tograntry/(#37) broke release-please's link to thev0.4.0release. It scanned all of history and applied theRelease-As: 0.2.0footer of fb23cb4 to both crates.This sets
last-release-shato a06c6c1, the last commit before #37, for both packages. Release-please then only reads the commits since v0.4.0 and takes the versions from the manifest.After merging, the release PR (#38) should update to grantry 0.5.0 and grantry-redis 0.1.0. Remove
last-release-shaagain after that release.