Repository navigation
Conversation
|
@SashaMIT is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configureServerSideSIWEchecked the session nonce, then calledverifySiweMessagewithout adomain.domainoption or the requestHost, and that value is forwarded to viem.Attacker already controls a site that can prompt a wallet signature. They do not already control this app's host or
SESSION_SECRET. Domain bind is the remaining guard.Not the SIWE Invalid Date class. Distinct from rainbow-me/rainbowkit#2690 (example-only iron-session verify). This is the published
connectkit-next-siwehelper.Test plan
npx tsx --test src/siweDomain.test.ts7/7evil.examplematchapp.example.comdomain: 'app.example.com'so Host is not the only bindMade with Cursor