Repository navigation
fix: isolate named client scopes and mixed registration collisions - #203
Merged
Merged
Conversation
Tony133
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #201. That PR fixed names inherited from Object.prototype when creating a fresh named registry. Two additional combinations still fail: child registrations mutate an inherited parent registry, and registering
__proto__after an unnamed client changes its prototype and bypasses duplicate detection.Create a local registry when a child adds a named client, retaining inherited clients while isolating parent and sibling scopes. Define named clients as own data properties, including when an unnamed client already exists. Independent siblings can reuse names; collisions with inherited names and actual client properties still fail.
These fixes were developed in my MariaDB fork in melroy89/fastify-mariadb#4, which also addresses startup cleanup. This PR ports only the registration fixes and their regression coverage to the mysql2-based plugin.
Validation with mysql2 3.24.4, Node.js 24, and isolated MySQL 9.7.2:
npm run lintand all 15 TypeScript assertions passed.