Repository navigation
Fix viceroy adapt for wasip2 with main function - #748
Open
chenyan2002 wants to merge 4 commits into
Open
chenyan2002 wants to merge 4 commits into
chenyan2002 wants to merge 4 commits into
Conversation
Contributor
|
Instead of trapping if the error code is nonzero, could it call |
Contributor
Author
|
Good idea. I also changed the synthesize function to use walrus, because importing "wasi:cli/exit" may change all the function index, and walrus ends up with much shorter code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a core module with main function is built with target
wasm32-wasip2, the entry export becomeswasi:cli/run@0.2.0#run, instead of_start.This means we need to synthesize a
_startfunction by callingwasi:cli/run@0.2.0#run, and callwasi:cli/exitif the return is non-zero.Another "simpler" option is to change the declaration in the adapter with
But that means we need yet another adapter binary.