Skip to content

update golangcilint version #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-gomez-fastly merged 2 commits into from
Sep 24, 2026
Merged

update golangcilint version #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e260c2
update golangcilint version
anthony-gomez-fastly Sep 24, 2026
f6de84a
Merge branch 'main' into upgrade-golangci-lint
anthony-gomez-fastly Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ FASTLY_API_KEY ?=
TEST_COMMAND ?= $(GO) test

# Tooling versions
GOLANGCI_LINT_VERSION = v2.10.1
GOLANGCI_LINT_VERSION = v2.14.0
BIN_DIR := $(CURDIR)/bin
GOLANGCI_LINT := $(BIN_DIR)/golangci-lint

Expand Down
15 changes: 8 additions & 7 deletions fastly/observability_custom_dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ type VisualizationConfig struct {
PlotType PlotType `json:"plot_type"`
}

type dashboardItemOption interface {
// DashboardItemOption is a functional option for configuring a DashboardItem.
type DashboardItemOption interface {
apply(*DashboardItem)
}
type optionFunc func(*DashboardItem)
Expand All @@ -128,37 +129,37 @@ func (f optionFunc) apply(di *DashboardItem) {
f(di)
}

func WithTitle(title string) dashboardItemOption {
func WithTitle(title string) DashboardItemOption {
Comment thread
anthony-gomez-fastly marked this conversation as resolved.
return optionFunc(func(di *DashboardItem) {
di.Title = title
})
}

func WithSubtitle(subtitle string) dashboardItemOption {
func WithSubtitle(subtitle string) DashboardItemOption {
return optionFunc(func(di *DashboardItem) {
di.Subtitle = subtitle
})
}

func WithSpan(span uint8) dashboardItemOption {
func WithSpan(span uint8) DashboardItemOption {
return optionFunc(func(di *DashboardItem) {
di.Span = span
})
}

func WithCalculationMethod(calculationMethod CalculationMethod) dashboardItemOption {
func WithCalculationMethod(calculationMethod CalculationMethod) DashboardItemOption {
return optionFunc(func(di *DashboardItem) {
di.Visualization.Config.CalculationMethod = &calculationMethod
})
}

func WithFormat(format VisualizationFormat) dashboardItemOption {
func WithFormat(format VisualizationFormat) DashboardItemOption {
return optionFunc(func(di *DashboardItem) {
di.Visualization.Config.Format = &format
})
}

func NewDashboardItem(sourceType DashboardSourceType, metrics []string, plotType PlotType, options ...dashboardItemOption) DashboardItem {
func NewDashboardItem(sourceType DashboardSourceType, metrics []string, plotType PlotType, options ...DashboardItemOption) DashboardItem {
di := DashboardItem{
DataSource: DashboardDataSource{
Type: sourceType,
Expand Down
Loading