Skip to content

add routing_configuration_id support to domain management domains API - #875

Merged
anthony-gomez-fastly merged 4 commits into
mainfrom
CDTOOL-1743-routing-config-domain-link
Sep 28, 2026
Merged

anthony-gomez-fastly merged 4 commits into
mainfrom
CDTOOL-1743-routing-config-domain-link

Conversation

@anthony-gomez-fastly

Copy link
Copy Markdown
Member

Change summary

Adds the RoutingConfigurationID field to the domains Data response and UpdateInput, and covers it with test/fixture updates.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@anthony-gomez-fastly
anthony-gomez-fastly requested a review from a team as a code owner September 25, 2026 17:26
@anthony-gomez-fastly
anthony-gomez-fastly requested review from jedisct1 and kpfleming and a lite review from Copilot September 25, 2026 17:26
@anthony-gomez-fastly
anthony-gomez-fastly marked this pull request as draft September 25, 2026 17:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

Adds routing_configuration_id support to the Domain Management Domains API models and updates the recorded fixtures/tests accordingly.

Changes:

  • Added RoutingConfigurationID to the domain response model (Data).
  • Added RoutingConfigurationID to UpdateInput and updated the update test/fixture to send/assert it.
  • Updated CHANGELOG.md with an enhancement entry.
File Description
fastly/​domainmanagement/​v1/​domains/​fixtures/​update.yaml Updates recorded PATCH request/response to include routing_configuration_id.
fastly/​domainmanagement/​v1/​domains/​api_update.go Adds RoutingConfigurationID to the update request payload model.
fastly/​domainmanagement/​v1/​domains/​api_test.go Extends update test to send and assert RoutingConfigurationID.
fastly/​domainmanagement/​v1/​domains/​api_response.go Adds RoutingConfigurationID to the domain Data response struct.
CHANGELOG.md Documents the new domain↔routing-config linking support.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread fastly/domainmanagement/v1/domains/api_update.go
Comment thread fastly/domainmanagement/v1/domains/api_test.go
@anthony-gomez-fastly
anthony-gomez-fastly force-pushed the CDTOOL-1743-routing-config-domain-link branch from 96679f8 to 7e793f8 Compare September 25, 2026 19:22
Adds the RoutingConfigurationID field to the domains Data response and
UpdateInput, and covers it with test/fixture updates.
@anthony-gomez-fastly
anthony-gomez-fastly force-pushed the CDTOOL-1743-routing-config-domain-link branch from 7e793f8 to 5942431 Compare September 25, 2026 19:26
@anthony-gomez-fastly
anthony-gomez-fastly marked this pull request as ready for review September 25, 2026 19:26
Comment thread fastly/domainmanagement/v1/domains/api_update.go
Comment thread fastly/domainmanagement/v1/routingconfigs/paths/api_test.go Outdated
@anthony-gomez-fastly
anthony-gomez-fastly merged commit b8a93a9 into main Sep 28, 2026
9 checks passed
@anthony-gomez-fastly
anthony-gomez-fastly deleted the CDTOOL-1743-routing-config-domain-link branch September 28, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants