add routing_configuration_id support to domain management domains API - #875
Merged
anthony-gomez-fastly merged 4 commits intoSep 28, 2026
Merged
Conversation
anthony-gomez-fastly
requested review from
jedisct1 and
kpfleming
and
a lite review from Copilot
September 25, 2026 17:26
anthony-gomez-fastly
marked this pull request as draft
September 25, 2026 17:35
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds routing_configuration_id support to the Domain Management Domains API models and updates the recorded fixtures/tests accordingly.
Changes:
- Added
RoutingConfigurationIDto the domain response model (Data). - Added
RoutingConfigurationIDtoUpdateInputand updated the update test/fixture to send/assert it. - Updated
CHANGELOG.mdwith an enhancement entry.
| File | Description |
|---|---|
| fastly/domainmanagement/v1/domains/fixtures/update.yaml | Updates recorded PATCH request/response to include routing_configuration_id. |
| fastly/domainmanagement/v1/domains/api_update.go | Adds RoutingConfigurationID to the update request payload model. |
| fastly/domainmanagement/v1/domains/api_test.go | Extends update test to send and assert RoutingConfigurationID. |
| fastly/domainmanagement/v1/domains/api_response.go | Adds RoutingConfigurationID to the domain Data response struct. |
| CHANGELOG.md | Documents the new domain↔routing-config linking support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
anthony-gomez-fastly
force-pushed
the
CDTOOL-1743-routing-config-domain-link
branch
from
September 25, 2026 19:22
96679f8 to
7e793f8
Compare
Adds the RoutingConfigurationID field to the domains Data response and UpdateInput, and covers it with test/fixture updates.
anthony-gomez-fastly
force-pushed
the
CDTOOL-1743-routing-config-domain-link
branch
from
September 25, 2026 19:26
7e793f8 to
5942431
Compare
anthony-gomez-fastly
marked this pull request as ready for review
September 25, 2026 19:26
kpfleming
reviewed
Sep 28, 2026
kpfleming
reviewed
Sep 28, 2026
kpfleming
approved these changes
Sep 28, 2026
…onfig-domain-link
This reverts commit f7fb166.
kpfleming
approved these changes
Sep 28, 2026
anthony-gomez-fastly
deleted the
CDTOOL-1743-routing-config-domain-link
branch
September 28, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Change summary
Adds the RoutingConfigurationID field to the domains Data response and UpdateInput, and covers it with test/fixture updates.
All Submissions:
New Feature Submissions:
Changes to Core Features: