Dedup tools install - #3749
Merged
Merged
Dedup tools install#3749
Conversation
Remove --platform in the Dockerfile to squash the FromPlatformFlagConstDisallowed warning and adhere to Docker best practices (see https://docs.docker.com/reference/build-checks/from-platform-flag-const-disallowed/).
Pin Python setuptools module version to 81.0.0, because vint has dependencies on pkg_resources, which was removed in 82. See https://discuss.python.org/t/pkg-resources-removal-how-to-go-from-there/106079 Update scripts/lint to check vint's exit code, because setuptools 81.0.0 outputs a warning about the deprecated pkg_resources module.
Only install the tools once in the Docker image and share them among all versions of Vim that are used for testing. This is a big productivity boost, because each installation of the tools takes several minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omit FROM --platform in the Dockerfile
Remove --platform in the Dockerfile to squash the
FromPlatformFlagConstDisallowed warning and adhere to Docker best
practices (see
https://docs.docker.com/reference/build-checks/from-platform-flag-const-disallowed/).
pin Python setuptools version
Pin Python setuptools module version to 81.0.0, because vint has
dependencies on pkg_resources, which was removed in 82. See
https://discuss.python.org/t/pkg-resources-removal-how-to-go-from-there/106079
Update scripts/lint to check vint's exit code, because setuptools 81.0.0
outputs a warning about the deprecated pkg_resources module.
install tools only once in docker image
Only install the tools once in the Docker image and share them among all
versions of Vim that are used for testing. This is a big productivity
boost, because each installation of the tools takes several minutes.