Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Chrome-specific (though broadly applicable) performance/DOM/layout optimization, based on Chrome profiler output, specifically targetting scroll performance in Perspective (which has complex
colspanandrowspanlayout invalidations).ResizeObserverbased sizing on the header only, which dramatically reduces forced relayouts readingoffsetWidth.predrawimplementation previously added to render scroll frames also (usingrequestAnimationFrameto flush synchronously).column_classesAPI so Perspective need not setstyleorclasson all cells.My totally non-scientific benchmark shows a 10ms ~> 2ms (per frame) improvement in non-JavaScript render time during scroll for a complex Perspective test case.