Update the sample app to use the new FCM registration API. - #1868
Open
leojaygoogle wants to merge 2 commits into
Open
Update the sample app to use the new FCM registration API.#1868leojaygoogle wants to merge 2 commits into
leojaygoogle wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase iOS SDK dependency to version 12.18.0 and integrates the new FCM registration and installation ID APIs. This includes adding registration callbacks to the AppDelegate, enabling FirebaseMessagingInstallationIdEnabled in Info.plist, and conditionally registering FCM in ViewController. Feedback was provided regarding a potential retain cycle in ViewController.swift where self is captured strongly inside an escaping closure, with a suggestion to use [weak self] instead.
Contributor
Author
Doris-Ge
reviewed
Sep 1, 2026
Doris-Ge
left a comment
Doris-Ge
left a comment
There was a problem hiding this comment.
Can we replace all the "token" references (in either code or comment) with "registration" or "Firebase Installation Id (FID)"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.