Repository navigation
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 4/5
- In
.github/workflows/publish-pypi.yml, upgrading pip on the host does not affect the pip used insidematurin-action’s manylinux container, so Linux builds may still use an unintended version. Bootstrap or pin pip inside the container too if consistent versions are required.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/publish-pypi.yml">
<violation number="1" location=".github/workflows/publish-pypi.yml:113">
P2: This upgrades only the host runner's pip; `maturin-action` runs Linux builds in a manylinux container, whose `python3 -m pip` installs remain unpinned. Bootstrap pip inside the action's Linux container as well if all wheel-build tooling must use this pinned version.</violation>
</file>
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
| python-version: '3.12' | ||
|
|
||
| - name: Bootstrap pip | ||
| run: python -m pip install --no-cache-dir -r .github/pip-bootstrap.txt |
There was a problem hiding this comment.
P2: This upgrades only the host runner's pip; maturin-action runs Linux builds in a manylinux container, whose python3 -m pip installs remain unpinned. Bootstrap pip inside the action's Linux container as well if all wheel-build tooling must use this pinned version.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/publish-pypi.yml, line 113:
<comment>This upgrades only the host runner's pip; `maturin-action` runs Linux builds in a manylinux container, whose `python3 -m pip` installs remain unpinned. Bootstrap pip inside the action's Linux container as well if all wheel-build tooling must use this pinned version.</comment>
<file context>
@@ -109,6 +109,9 @@ jobs:
python-version: '3.12'
+ - name: Bootstrap pip
+ run: python -m pip install --no-cache-dir -r .github/pip-bootstrap.txt
+
- name: Build wheel
</file context>
|
No rebuild needed after merge: the CI and PyPI publish workflows use the pinned pip on their next run. The red |
capy-ai
Bot
requested review from
mogery
and removed request for
abimaelmartell
October 23, 2026 07:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs pip from a hash-pinned bootstrap file (
.github/pip-bootstrap.txt, pip 26.2.2) before any other pip command in the jobs that run pip: the OCR runtime smoke job inci.ymland the wheel build job inpublish-pypi.yml.The bootstrap file uses
--require-hashesand--only-binary=:all:, so the pip upgrade itself is verified against the pinned wheel hash. Existing action pins are unchanged.Verified in a
python:3.12-slimcontainer (pip 25.0.1):python -m pip install --no-cache-dir -r .github/pip-bootstrap.txtresults inpip 26.2.2.No image or deployment is affected; the change takes effect on the next workflow run.
Summary by cubic
Pins the pip version used in CI to pip 26.2.2 by installing it from a hash-pinned bootstrap file (
.github/pip-bootstrap.txt) before any other pip command. The bootstrap uses--require-hashesand--only-binary=:all:, so the upgrade is verified against the pinned wheel hash.The bootstrap step runs in the OCR runtime smoke job in
ci.ymland the wheel build job inpublish-pypi.yml. Existing action pins are unchanged, and the change takes effect on the next workflow run without affecting any image or deployment.Written for commit a57ca6e. Summary will update on new commits.