delta_diff_generator: Drop unused scratch_blocks_used variable - #59
Merged
Merged
Conversation
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused cleanup removes only dead code without changing behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Removes an unused variable that causes GCC 16.2.1 builds to fail.
Changes:
- Removes
scratch_blocks_usedand its unused accumulation.
| File | Description |
|---|---|
src/update_engine/delta_diff_generator.cc |
Removes unused scratch-block accounting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 16.2.1 treats this as a fatal error. This variable hasn't been used since 2010 in 4b8740f! I have build tested the change.