Repository navigation
Conversation
Adds iOS-only isResponsiveCaptureSupported and setResponsiveCaptureEnabled to AVFoundationCamera. Responsive capture is off by default, requires zero-shutter-lag, and is applied together with it in one session configuration.
fc769ce to
12f4a3c
Compare
|
Hi @toyaji, thank you for your contribution! This pull request has been converted to a draft because it does not appear to follow our pull request template:
How to fix this
Click here for the raw Markdown of the Pre-Review Checklist to copy and paste## Pre-Review Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] page, which explains my responsibilities.
- [ ] I read and followed the [relevant style guides] and ran [the auto-formatter].
- [ ] I signed the [CLA].
- [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]`
- [ ] I [linked to at least one issue that this PR fixes] in the description above.
- [ ] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
- [ ] I updated/added any relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
<!-- Links -->
[Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[AI contribution guidelines]: https://github.com/flutter/flutter/blob/master/CONTRIBUTING.ai.md#pull-requests
[Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[the auto-formatter]: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
[CLA]: https://cla.developers.google.com/
[Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[the version and CHANGELOG instructions]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates
[semantic versioning]: https://dart.dev/tools/pub/versioning#semantic-versions
[repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests |
There was a problem hiding this comment.
Code Review
This pull request introduces iOS-only support for responsive capture in the camera_avfoundation package by adding isResponsiveCaptureSupported and setResponsiveCaptureEnabled methods. The changes span the Pigeon definitions, Dart platform interface implementation, Swift plugin code, and native AVCapturePhotoOutput handling, coordinating responsive capture with zero-shutter-lag settings. Unit tests, documentation, and example code have also been updated to support these new features. There are no review comments, and I have no feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request adds support for iOS-only responsive capture (isResponsiveCaptureSupported and setResponsiveCaptureEnabled) to the camera_avfoundation package. It introduces the necessary platform interface methods, Pigeon definitions, Swift implementation details (including managing the dependency on zero-shutter-lag), documentation, and comprehensive unit tests. There are no review comments to address, and I have no additional feedback to provide.
Adds an iOS-only, opt-in API for
AVCapturePhotoOutputresponsive capture toAVFoundationCamera:isResponsiveCaptureSupported(cameraId)andsetResponsiveCaptureEnabled(cameraId, enabled).With responsive capture, the next photo capture can start while the previous photo is still processing. It is off by default and does not change
setZeroShutterLagEnabledor any existing behavior.Fixes flutter/flutter#197111
Two captures in a row (illustrative, not to scale):
Why only in
camera_avfoundationCameraPlatform.instance.takePictureagain before the previous call returns.CameraController.takePicturedoes not allow overlapping calls, so most apps do not need it.camera_platform_interfaceorcamera_android_camerax.CameraPlatform.instanceis anAVFoundationCamerabefore calling it, likeGoogleMapsFlutterAndroidin google_maps_flutter_android. The README shows this.Details
AVCapturePhotoOutputdoes. When unsupported,isResponsiveCaptureSupportedreturns false and enabling it is a no-op, so the plugin never sets an unsupported flag (which throws).beginConfiguration/commitConfiguration. Disabling zero-shutter-lag turns responsive capture off first; enabling it again restores the request. Both are re-applied after switching cameras, including while recording.uniqueID. Responsive capture uses more memory, which the docs mention.Testing
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2