Repository navigation
fix(code-slack): make SLACK_SIGNING_SECRET optional in Socket Mode - #111
Merged
Merged
Conversation
The bot connects with Socket Mode and authenticates with the app token, so it never verifies request signatures. The secret was required at startup but unused. Make it optional (still validated when set) and drop it from the setup examples. Bolt constructs in Socket Mode without it. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SLACK_SIGNING_SECRETwas required at startup, but the bot runs in Socket Mode and never verifies request signatures. It is now optional and still validated when set..env.exampleno longer tell operators to set it.Verification
Appin Socket Mode without a signing secret.npx vitest runpasses (226 tests, with the lockfile's env-core 0.13.11 and zod 4.6.7).tsc --noEmit(typescript@5) andbiome ci .pass.🤖 Generated with Claude Code