chore: bump version to 0.1.15 for the Docker test-flow fixes - #143
Merged
Conversation
Releases the fixes from #140, which game-ci/unity-test-runner cannot pick up until a release exists - it downloads the published binary (cliVersion: latest), so it is still running v0.1.14. Both of unity-test-runner#310's remaining failure modes are fixed by this release, and nothing else: - Linux: `game-ci test --docker` ran the tests, passed them (<test-run result="Passed" total="5" passed="5">), and then failed the run anyway - validateBuild() scrapes the log for a "# Build results #" section that only a real build emits. - Windows: rejected outright by the hostPlatform guard, which existed because the container entrypoint.ps1 had no RUN_TESTS branch. It has one now, reusing the shared steps/test.ps1. Also carries the missing /UnityTestRunnerAction mount, without which --testPlatforms=standalone fails on `cp -R` (on Linux too, not just Windows).
|
Warning Review limit reachedNext included review available in 22 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts a release for the fixes merged in #140.
game-ci/unity-test-runnerdownloads the published binary (cliVersion: latest), so it is still runningv0.1.14and cannot pick them up until a release exists.Verified against a real matrix
unity-test-runner#310 now gets all the way through Unity licensing and runs its tests successfully:
…and then fails anyway, for exactly two reasons — both fixed in #140, neither released:
Linux —
validateBuild()scrapes the container log for a# Build results #section that only a real build ever emits, so a fully passing suite was reported as a build failure:Windows — rejected outright by the
hostPlatformguard (correct at the time: the containerentrypoint.ps1had noRUN_TESTSbranch and would have silently run a build). It has one now, reusing the sharedsteps/test.ps1:This release also carries the missing
/UnityTestRunnerActionmount, without which--testPlatforms=standalonedies oncp -R— on Linux too, not just Windows.After merge
Publish the
v0.1.15release to triggerrelease-cli.yml, which builds and attaches the per-platform binaries.🤖 Generated with Claude Code