Repository navigation
fix: forward pointer drags with coordinates to macOS views - #4
Conversation
Ordinary views on macOS received onPointerDown/onPointerUp at (0,0) and never onPointerMove: GeaRootClickBridge handled only the press recognizer's began/ended states and dispatched events without coordinates. Canvases worked because GeaCanvasView feeds TouchRuntime directly. The bridge now converts the recognizer location to tree coordinates (undoing applyViewStyle's y-flip and adding the root's tree origin), fills the same payload TouchRuntime's dispatchPointer does, dispatches touchmove to the pressed node on the changed state, and suppresses the click after a drag past TouchRuntime's 16 px slop. Split-view panes pass their layout origin to the bridge on every sync. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe macOS root bridge now tracks press gestures, dispatches coordinate-bearing touch events, and sends a click only when a press ends without being marked as a drag. Gesture coordinates include the root or pane origin. ChangesmacOS Press Gesture Events
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change adds drag-aware pointer events and click suppression on macOS. No concrete merge-blocking issue was found. The author notes only a manual probe was run and other controls were not re-tested. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
GeaRootClickBridgenow sends real coordinates, forwards drag moves to the pressed view, and skips the click after a drag.