Skip to content

Bind JSX scroll listeners to their target node #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dogukani merged 1 commit into from
Sep 24, 2026
Merged

Bind JSX scroll listeners to their target node #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/targets/cpp/runtime/gea_runtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25126,9 +25126,10 @@ bool isDocumentLevelEvent(const Node& node, const std::string& name) {
* is gated on the node's live token instead -- a rebuilt subtree leaves an
* inert closure behind rather than a second generation of the handler.
*
* Everything else is delegated to the BODY and gated by `containsNode`; see
* Bubbling events are delegated to the BODY and gated by `containsNode`; see
* the no-argument `addNodeListener` for why, and `recordNodeSubscription` for
* how it is released with the node.
* how it is released with the node. Scroll stays on its target because it does
* not bubble.
*/
template <typename Node, typename Invoke>
void bindNodeListener(Node& node, const std::string& name, Invoke invoke) {
Expand All @@ -25155,6 +25156,10 @@ void bindNodeListener(Node& node, const std::string& name, Invoke invoke) {
});
return;
}
if (name == "scroll") {
target.addEventListener(name.c_str(), std::move(run));
return;
}
const auto listenerId = gea::embedded::ui::Document::instance().body().addEventListener(
name.c_str(), [target, run](gea::framework::events::PointerEvent& event) mutable {
if (!gea::embedded::ui::Tree::instance().containsNode(target.id(), event.targetId)) return;
Expand Down
Loading